refactor: clients section to dynamically fetch from app-directory#5380
refactor: clients section to dynamically fetch from app-directory#5380eduardomozart wants to merge 5 commits into
Conversation
ReenigneArcher
left a comment
ReenigneArcher
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I will wait to run CI as there is an ongoing issue with sonar at the moment. https://community.sonarsource.com/t/sonar-seems-to-now-be-including-submodules-when-scanning-please-revert/184681
Could you also update the featured apps section in the web-ui to use the download images (like for Microsoft Store and Apple Store) when available?
eduardomozart
changed the title
|
Done! |
390b4fe to
cde1d8f
Compare
Bundle ReportChanges will increase total bundle size by 417 bytes (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
Files in
|
ReenigneArcher
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ReenigneArcher
left a comment
ReenigneArcher
left a comment
There was a problem hiding this comment.
Sorry for the delay on the review.
Looks like there's some lint errors, as well as CodeQL issues to resolve. The CodeQL is going to be pretty strict about url parsing, so those should be hardened to ensure the urls start with what's expected. Probably better to use a URL object (https://itsourcecode.com/javascript-tutorial/how-javascript-get-domain-from-url-4-methods/)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5380 +/- ##
=========================================
Coverage ? 26.87%
=========================================
Files ? 111
Lines ? 25406
Branches ? 11232
=========================================
Hits ? 6827
Misses ? 15352
Partials ? 3227
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
eduardomozart
left a comment
eduardomozart
left a comment
There was a problem hiding this comment.
Applied a fix. It seems to be working just fine on my side.
be3e5c0 to
bdffbe9
Compare
|
|
Thanks! I'll test out the web-ui shortly and if no issues I think this is good to go. |
3 participants
Description
This PR refactors the
gh-pages-templateto dynamically fetch client information from the centralizedsunshine.jsondirectory rather than relying on a staticclients.ymlfile.gh-pages-template/_data/clients.ymlas its static data is no longer necessary.gh-pages-template/index.htmlto fetchhttps://app.lizardbyte.dev/app-directory/sunshine.jsonand build the client DOM dynamically using JavaScript.sunshine.jsonschema.Note: This PR requires LizardByte/app-directory#40 to be merged first, as it relies on the newly defined
iconsanddownloadsschema insunshine.json.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage